On Fri, Sep 14, 2012 at 04:13:57PM +0200, Linus Walleij wrote: > But the parent driver is using regmap, sand you seem not to use the > struct da9055 > for anything else than passing reads/writes, so isn't it simpler to just pass > the struct regmap * and use update_bits etc directly and remove a layer of > indirection? > I'm very uncertain but Mark will know the proper design pattern. Either way is fine - usually the device specific functions end up being static inlines in the header so the code is the same. It really depends if it's useful to have the full device pointer around for other things. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html