Re: [PATCH] input: fix input_open_file() accessing out-of-bound buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David,

On Thu, Sep 13, 2012 at 06:18:17PM +0200, David Herrmann wrote:
> Hi Dmitry
> 
> On Thu, Sep 13, 2012 at 6:17 PM, David Herrmann
> <dh.herrmann@xxxxxxxxxxxxxx> wrote:
> > The "input_table" array is very small and we cannot be sure that the file
> > the user opens has a minor-ID below 256 (8 << 5). Hence, simply check that
> > the minor isn't out-of-bounds. If it is, return -ENODEV.
> >
> > Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxxxxxxx>
> > Cc: <stable@xxxxxxxxxx>
> 
> This should be "Cc: <stable@xxxxxxxxxxxxxxx>". Sorry for the typo.

register_chrdev() reserves exactly 256 minors so it is not possible for
input_open_file() to be called with minor that will get us out of
bounds.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux