On Fri, Aug 17, 2012 at 3:17 PM, Christopher Heiny <cheiny@xxxxxxxxxxxxx> wrote: Verbose commit message. > Signed-off-by: Christopher Heiny <cheiny@xxxxxxxxxxxxx> > +#include <linux/hrtimer.h> > +#include <linux/kernel.h> > +#include <linux/rmi.h> > +#include <linux/slab.h> > +#include <linux/version.h> > +#include <linux/delay.h> This is not using the existing in-kernel framework for ADC (which I think is what you're doing), in this case use the IIO subsystem so consult drivers/iio/adc and be inspired. Just exposing a set of weird sysfs files to userspace is not proper. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html