On Thu, Aug 23, 2012 at 07:19:36PM +0200, Lars-Peter Clausen wrote: > On 08/23/2012 07:12 PM, Lars-Peter Clausen wrote: > >[...] > > Or maybe just use the runtime pm API for this. This probably makes even more > > sense and grab a reference to the pm context when the enable() is called, > > release it when disable() is called and also grab it before calling the > > device's config callback and release it afterward. > > Btw. this seems to be exactly what the pwm-tiecap and pwm-tiehrpwm drivers > already do today. I'd just make that a core PWM framework feature. Using runtime PM for this sounds indeed like the most generic approach. I'm not very familiar with the API, but I thought it required explicit architecture or bus support (or the driver itself can provide hooks via pm_ops), so it might be difficult to implement for platforms that don't have working runtime PM support. I'll have to look into this some more. Anyway, if we add this kind of support to the PWM core we should take it through next first. For drivers that are currently broken, they should be, as you said, fixed by enabling the clock before reconfiguring and disable it after (unless the PWM is enabled) like Tegra does. Thierry
Attachment:
pgpX3Puyf51gz.pgp
Description: PGP signature
