On Wed, 22 Aug 2012, Simon Farnsworth wrote:
> This QUANTA device is driven by the generic hid-multitouch.ko driver, and
> therefore shouldn't be in the special drivers list.
>
> I've gone over the entire special drivers list in hid-core.c; this is the
> only device I spotted that's listed as needing a special driver, but doesn't
> have an entry in a struct hid_driver's id_table.
>
> Signed-off-by: Simon Farnsworth <simon.farnsworth@xxxxxxxxxxxx>
> ---
>
> Applying just this patch is enough to fix the problem I described in my mail
> "QUANTA touchscreen controller integrated in HP2310ti no longer recognised
> (regression in 3.5 and later as compared to 3.3)".
>
> This looks like an oversight in commit 4fa3a58; that commit removes most
> multitouch screens from this list, but missed this one. Henrik should be
> able to confirm, though, so I'd appreciate his sign-off.
>
> drivers/hid/hid-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 60ea284..8bf8a64 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1624,7 +1624,6 @@ static const struct hid_device_id hid_have_special_driver[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_ORTEK, USB_DEVICE_ID_ORTEK_WKB2000) },
> { HID_USB_DEVICE(USB_VENDOR_ID_PETALYNX, USB_DEVICE_ID_PETALYNX_MAXTER_REMOTE) },
> { HID_USB_DEVICE(USB_VENDOR_ID_PRIMAX, USB_DEVICE_ID_PRIMAX_KEYBOARD) },
> - { HID_USB_DEVICE(USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_KONE) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_ARVO) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_ISKU) },
Good catch, thank you. I will be pushing this to Linus for 3.6 still.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
