On Wed, 8 Aug 2012, Dmitry Torokhov wrote: > On Wednesday, August 08, 2012 09:36:51 PM Jesper Juhl wrote: > > On Wed, 8 Aug 2012, Sachin Kamat wrote: > > > On 7 August 2012 23:46, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote: > > > > If omap4_keypad_parse_dt() does not return 0 (zero) in > > > > omap4_keypad_probe() we will leak the memory we allocated for > > > > 'keypad_data' with kzalloc() when we return and the variable goes out > > > > of scope. > > > > > > How about using devm_kzalloc() instead which will take care of freeing > > > the memory on detach? > > > > Perhaps. I'm not (yet) familiar with how that function works, so I had > > not considered it. I'll look into it. > > Actually please not yet - I guess at some point I'll have to add devm_* > variants for input_device_* operations but for now I prefer not to mix > the 2 styles of managing resources. > > BTW, I think I need to redo a few patches so I plan on folding this fix > into the original change. > Ok. I'll just leave this alone for now then and let you do whatever you feel is best :-) . -- Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
