Re: [PATCH v4] Input: synaptics - handle out of bounds values from the hardware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 25, 2012 at 10:50:15AM +0800, Daniel Kurtz wrote:
> > +       /* Convert wrap-around values to negative */
> > +       if (hw->x > X_MAX_POSITIVE)
> > +               hw->x = hw->x - (1 << ABS_POS_BITS);
> 
> Hi Seth,
> 
> Perhaps:
> hw->x -= (1 << ABS_POS_BITS);

It makes no difference to me, either way it works the same. I don't
think I'll send another patch just to change this though, unless Dmitry
asks for it :)

> Either way, it looks good, thanks!
> 
> Reviewed-by: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>

Thanks!

Seth
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux