Re: [PATCH v3] HID: Allow drivers to be their own listener

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 20 Jul 2012, Henrik Rydberg wrote:

> > hid-picolcd and hid-wiimote do not allow any of hidinput, hiddev or hidraw
> > to claim the device but still want to remain on the bus. Hence, if a
> > driver uses the raw_event callback but no other listener claimed the
> > device, we still leave it on the bus as the driver handles everything by
> > itself. It thus becomes its own listener.
> > 
> > Under some circumstances (eg., hidinput_connect() fails and raw_event set)
> > a device may be left on the bus even though it requires external
> > listeners. But then if hidinput_connect() fails there are bigger issues
> > than a device that is left unhandled. So we can safely use this heuristic
> > to avoid adding another flag for special devices like hid-picolcd and
> > hid-wiimote.
> > 
> > This also removes the ugly hack from hid-picolcd as this is no longer
> > required.
> > 
> > Signed-off-by: David Herrmann <dh.herrmann@xxxxxxxxxxxxxx>
> > ---
> > Sorry for the delay. I had two exams this week that got into my way. Anyway, I
> > hope this time the patch looks ok.
> > 
> > Thanks to Henrik for reviewing it the previous times.
> 
> Thanks, David, looking good now.
> 
>     Acked-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>

Now queued for 3.6. Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux