Re: [PATCH] input: Request threaded-only IRQs with IRQF_ONESHOT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



H Lars, Thomas,

On Mon, Jul 02, 2012 at 01:44:20PM +0200, Lars-Peter Clausen wrote:
> Since commit 1c6c69525b ("genirq: Reject bogus threaded irq requests") threaded
> IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise
> the request will fail. This patch adds the IRQF_ONESHOT to IIO drivers where it
> is missing. Not modified by this patch are those drivers where the requested IRQ
> will always be a nested IRQ (e.g. because it's part of an MFD), since for this
> special case IRQF_ONESHOT is not required to be specified when requesting the
> IRQ.

This is not very helpful. Why, instead of bailing out, genirq case does
not add IRQF_ONESHOT itself to the flags? Then we would not need to
alter zillions of drivers.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux