On Wed, 27 Jun 2012, Alan Cox wrote: > From: Alan Cox <alan@xxxxxxxxxxxxxxx> > > Fix harmless reference off end of array > > Reported-by: <dcb314@xxxxxxxxxxx> > Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?43861 > Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx> > --- > > drivers/input/keyboard/lm8333.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/lm8333.c b/drivers/input/keyboard/lm8333.c > index ca168a6..081fd9e 100644 > --- a/drivers/input/keyboard/lm8333.c > +++ b/drivers/input/keyboard/lm8333.c > @@ -91,7 +91,7 @@ static void lm8333_key_handler(struct lm8333 *lm8333) > return; > } > > - for (i = 0; keys[i] && i < LM8333_FIFO_TRANSFER_SIZE; i++) { > + for (i = 0; i < LM8333_FIFO_TRANSFER_SIZE && keys[i]; i++) { > pressed = keys[i] & 0x80; > code = keys[i] & 0x7f; > Applied to trivial, thanks Alan. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html