Hi all,
On Mon, Jun 25, 2012 at 11:27:37AM +0200, Simon Budig wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Henrik.
>
> On 06/25/2012 10:51 AM, Henrik Rydberg wrote:
> >> [Sysfs files]
> >
> > I would very much prefer if the driver functioned well without
> > such settings, since they complicate userspace and are not likely
> > to ever go away. Oh well.
>
> I would prefer to have the touchscreen adjust itself as well,
> unfortunately this is not available and you definitely need different
> settings depending for different touch setups.
>
> Would an ioctl() be more acceptable? Would make it harder to adjust it
> in startup scripts etc. though.
>
> >> + if (error) { + dev_err(&tsdata->client->dev, + "Unable to
> >> write to fetch data, error: %d\n", error); + goto out; + }
> >
> > No risk of flooding the logs here? Perhaps rate-limit the outputs?
>
> Hmm, possible. Can you point me to a driver that does this in a sane
> fashion?
>
> >> + for (i = 0; i < MAX_SUPPORT_POINTS; i++) { + u8 *buf =
> >> &rdbuf[i * 4]; + bool down; + + type = buf[5] >> 6; + /*
> >> ignore Reserved events */ + if (type == TOUCH_EVENT_RESERVED) +
> >> continue;
> >
> > As per the implementation by Olivier, it seems these touches may
> > get stuck in the down position. No?
>
> Not if you do the loop over all 5 event entries in the report. The
> n_touches field really contains the number of fingers on the touch,
> not the number of events in the report. Since the "down"-events
> conveniently are sorted to the beginning of the report for the type A
> protocol it was enough to to just iterate over these (we ignored the
> UP-events anyway). Now that we need them we just iterate over all of
> the events and there they are.
Indeed in my code I did the loop up to n_touches, not always on the five
entries. I'll check that.
By the way, the check of the frame CRC is missing.
>
> >> + tsdata->threshold = edt_ft5x06_i2c_register_read(tsdata, +
> >> WORK_REGISTER_THRESHOLD); + tsdata->gain =
> >> edt_ft5x06_i2c_register_read(tsdata, + WORK_REGISTER_GAIN);
> >> + tsdata->offset = edt_ft5x06_i2c_register_read(tsdata, +
> >> WORK_REGISTER_OFFSET); + tsdata->report_rate =
> >> edt_ft5x06_i2c_register_read(tsdata, +
> >> WORK_REGISTER_REPORT_RATE); + tsdata->num_x =
> >> edt_ft5x06_i2c_register_read(tsdata, +
> >> WORK_REGISTER_NUM_X); + tsdata->num_y =
> >> edt_ft5x06_i2c_register_read(tsdata, +
> >> WORK_REGISTER_NUM_Y); + + dev_dbg(&client->dev, + "Model \"%s\",
> >> Rev. \"%s\", %dx%d sensors\n", + tsdata->name, fw_version,
> >> tsdata->num_x, tsdata->num_y); + + input->name = tsdata->name; +
> >> input->id.bustype = BUS_I2C; + input->dev.parent = &client->dev;
> >> + + __set_bit(EV_SYN, input->evbit); + __set_bit(EV_KEY,
> >> input->evbit); + __set_bit(EV_ABS, input->evbit); +
> >> __set_bit(BTN_TOUCH, input->keybit); +
> >> input_set_abs_params(input, ABS_X, 0, tsdata->num_x * 64 - 1, 0,
> >> 0); + input_set_abs_params(input, ABS_Y, 0, tsdata->num_y * 64 -
> >> 1, 0, 0); + input_set_abs_params(input, ABS_MT_POSITION_X, +
> >> 0, tsdata->num_x * 64 - 1, 0, 0); + input_set_abs_params(input,
> >> ABS_MT_POSITION_Y, + 0, tsdata->num_y * 64 - 1, 0, 0); +
> >> input_mt_init_slots(input, MAX_SUPPORT_POINTS);
> >
> > No error checking here?
>
> I guess you're referring to the _register_read()s? Yeah, they probably
> could use some.
>
> Thanks,
> Simon
>
> - --
> Simon Budig kernel concepts GmbH
> simon.budig@xxxxxxxxxxxxxxxxx Sieghuetter Hauptweg 48
> +49-271-771091-17 D-57072 Siegen
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk/oLwkACgkQO2O/RXesiHCSHgCdHV7OHSfBVrePLL4F19j+MwvH
> lkYAoIfI9X61yTWwG1AFcaGiJhefdShr
> =wpmW
> -----END PGP SIGNATURE-----
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Olivier
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
