On 21/06/12 10:56, Dmitry Torokhov wrote: > On Mon, Jun 11, 2012 at 09:44:51PM +0200, Roland Stigge wrote: >> This patch adds a driver for the key scan interface of the LPC32xx SoC >> >> Signed-off-by: Roland Stigge <stigge@xxxxxxxxx> >> For the DT binding: Acked-by: Rob Herring <rob.herring@xxxxxxxxxxx> > > Not a real review, just a quick question - if th driver is DT-only now > do we need to have the platform data or it would make more sense to read > DT-bindings and fill the main device structure directly? And: >> + >> + matrix_keypad_build_keymap(NULL, NULL, kscandat->kscancfg->matrix_sz, >> + kscandat->kscancfg->matrix_sz, >> + kscandat->kscancfg->keymap, kscandat->input); > > This function may fail now. I'm addressing both issues in a updated patch. Thanks for the feedback, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
