On Tuesday, June 05, 2012 03:55:31 PM devendra.aaru wrote: > Hi Jiri, > > Thanks for the review. > > On Tue, Jun 5, 2012 at 3:11 PM, Jiri Kosina <jkosina@xxxxxxx> wrote: > >> diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig > >> index cd6268c..044378f 100644 > >> --- a/drivers/input/mouse/Kconfig > >> +++ b/drivers/input/mouse/Kconfig > >> @@ -152,7 +152,7 @@ config MOUSE_SERIAL > >> config MOUSE_APPLETOUCH > >> tristate "Apple USB Touchpad support" > >> depends on USB_ARCH_HAS_HCD > >> - select USB > >> + select USB if USB_SUPPORT && USB_ARCH_HAS_HCD > > > > Depending on USB_ARCH_HAS_HCD and then having it as a part of 'if' > > condition seems odd. > > So, > + depends on USB_SUPPORT && USB_ARCH_HAS_HCD > will be good ? I'd rather we "select"ed the new symbol. So please do depends on USB_ARCH_HAS_HCD select USB + select USB_SUPPORT Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
