Re: [Patch] Add Apple wireless keyboard to the quirk list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 28 May 2012, Daniel Nicoletti wrote:

> some time ago I sent the patch to probe the battery status of devices,
> but Jeremy improved it to go to hid-input and created a quirk list,
> at that time I was quite busy with other projects that I didn't had the
> chance to put my model on that list, so, now that the patch got upstream
> I'm having I/O errors when reading that...
> 
> I'd also suggest to include all the other keyboard models between his and
> mine, but I don't know if doing this without testing is ok.

Daniel,

I'd prefer adding those only after verification that the battery status is 
reported on those devices in compatible way as well.

> I've tested and with this, it works just fine, thanks.

Thanks for the patch. It's however missing your Signed-off-by: line, could 
you please resend the patch including it, so that I could apply it?

Thanks.

> 
> Daniel.
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 132b001..33d88d1 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -301,6 +301,9 @@ static const struct hid_device_id hid_battery_quirks[] = {
>         { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
>                                USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI),
>           HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
> +       { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
> +                              USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
> +         HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
>         {}
>  };

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux