Re: [PATCH 2/2] input: wacom - Bamboo One 1024 pressure fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 20, 2012 at 6:43 PM,  <chris@xxxxxxxxxxxxxx> wrote:
> From: Chris Bagwell <chris@xxxxxxxxxxxxxx>
>
> Bamboo One's with ID of 0x6a and 0x6b were added with correct
> indication of 1024 pressure levels but the Graphire packet routine
> was only looking at 9 bits.  Increased to 10 bits.
>
> This bug caused these devices to roll over to zero pressure at half
> way mark.
>
> The other devices using this routine only support 256 or 512 range
> and look to fix unused bits at zero.
>
> Signed-off-by: Chris Bagwell <chris@xxxxxxxxxxxxxx>
> Reported-by: Tushant Mirchandani <tushantin@xxxxxxxxx>

Reviewed-by: Ping Cheng <pingc@xxxxxxxxx>

Ping

> ---
>  drivers/input/tablet/wacom_wac.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
> index 004bc1b..869e057 100644
> --- a/drivers/input/tablet/wacom_wac.c
> +++ b/drivers/input/tablet/wacom_wac.c
> @@ -248,7 +248,7 @@ static int wacom_graphire_irq(struct wacom_wac *wacom)
>                input_report_abs(input, ABS_X, le16_to_cpup((__le16 *)&data[2]));
>                input_report_abs(input, ABS_Y, le16_to_cpup((__le16 *)&data[4]));
>                if (wacom->tool[0] != BTN_TOOL_MOUSE) {
> -                       input_report_abs(input, ABS_PRESSURE, data[6] | ((data[7] & 0x01) << 8));
> +                       input_report_abs(input, ABS_PRESSURE, data[6] | ((data[7] & 0x03) << 8));
>                        input_report_key(input, BTN_TOUCH, data[1] & 0x01);
>                        input_report_key(input, BTN_STYLUS, data[1] & 0x02);
>                        input_report_key(input, BTN_STYLUS2, data[1] & 0x04);
> --
> 1.7.10.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux