Re: [PATCH 1/1] HID: uclogic: Add support for UC-Logic TWHL850

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 13 May 2012, Nikolai Kondrashov wrote:

> Add support for UC-Logic Wireless Tablet TWHL850.
> It is known to be sold as Genius MousePen M508W.
> 
> This tablet has a bug in the default (compatibility) mode which is used in this
> driver: frame button assignments are mixed up. This is to be fixed with a driver
> using proprietary protocol, which is to be fully reverse-engineered yet.
> 
> Signed-off-by: Nikolai Kondrashov <spbnick@xxxxxxxxx>
> ---
> 
> This is based on 3.4-rc7.
> 
> I'm a bit unsure about the IFACE_RDESC_FIXUP macro. Please tell if it's not
> acceptable and I'll rewrite that part in the required way.

Well, I actually think it causes the code to be less readable compared to 
having it fully expanded.

So I'd like to ask you to drop that strange macro and just put a fully 
expanded version there ... it's 10 lines more or so, but readable 
immediately without thinking.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux