Hi, Bo
On 5/7/2012 10:27 AM, Bo Shen wrote:
The default trigger mode of QT1070 is IRQF_TRIGGER_LOW,
Using TRQF_TRIGGER_FALLING to replace IRQF_TRIGGER_LOW | IRQF_ONESHOT.
Add a workaround for some SOC which can not distinguish the falling
and rising change on I/O lines.
Signed-off-by: Bo Shen<voice.shen@xxxxxxxxx>
---
drivers/input/keyboard/qt1070.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c
index 0b7b2f8..1855e3d 100644
--- a/drivers/input/keyboard/qt1070.c
+++ b/drivers/input/keyboard/qt1070.c
@@ -201,10 +201,17 @@ static int __devinit qt1070_probe(struct i2c_client *client,
msleep(QT1070_RESET_TIME);
err = request_threaded_irq(client->irq, NULL, qt1070_interrupt,
- IRQF_TRIGGER_NONE, client->dev.driver->name, data);
+ IRQF_TRIGGER_FALLING, client->dev.driver->name, data);
if (err) {
- dev_err(&client->dev, "fail to request irq\n");
- goto err_free_mem;
+ /* This is a workaround for some SOC which can not distinguish
+ * falling and rising change on I/O lines.
+ */
+ err = request_threaded_irq(client->irq, NULL, qt1070_interrupt,
+ IRQF_TRIGGER_NONE, client->dev.driver->name, data);
I think here using IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING is better
than using IRQF_TRIGGER_NONE.
Since for the QT1070 driver it can handle irq interrupt of falling (can
read valid data from QT1070) or rising (read but no valid data).
But if set to IRQF_TRIGGER_NONE, for some hardware it maybe caused by
IRQF_TRIGGER_HIGH or IRQF_TRIGGER_LOW. That is not what you expected.
+ if (err) {
+ dev_err(&client->dev, "fail to request irq\n");
+ goto err_free_mem;
+ }
}
/* Register the input device */
Best Regards,
Josh Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
