Re: [PATCH v8] input: Add Synaptics NavPoint (PXA27x SSP/SPI) driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Dmitry,

--- On Wed, 9/5/12, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> The driver looks excellent now, I have just a few nits:
> 
> - you do not need separate mutex and counter; it is
> perfectly fine to
>   use input device's ones;
> 
> - we don't really need min/max for coordinates: the defaults
> are good
>   for your device and if more devices come with
> different limits one
>   could adjust limits via EVIOCSABS ioctls.
> 
> I also took libertu if rearranging the code a bit so it
> flows more like
> the rest of the input drivers. Could you please tell me if
> the patch
> below breaks your device or if it still works?

It still works! Thanks.

Will you apply a combined patch (my patch v8 + your patch),
or should I submit them as patch v9?

Regards,
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux