On 5/2/2012 4:35 PM, javier Martin wrote:
Hi,
I was testing qt1070 driver with my Visstrim SM10 board when I found
out IRQs where not triggered properly.
I had to come up with the following patch in order to solve it:
diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c
index 0b7b2f8..e8b6ae3 100644
--- a/drivers/input/keyboard/qt1070.c
+++ b/drivers/input/keyboard/qt1070.c
@@ -201,7 +201,7 @@ static int __devinit qt1070_probe(struct i2c_client *client,
msleep(QT1070_RESET_TIME);
err = request_threaded_irq(client->irq, NULL, qt1070_interrupt,
- IRQF_TRIGGER_NONE, client->dev.driver->name, data);
+ IRQF_TRIGGER_FALLING, client->dev.driver->name, data);
if (err) {
dev_err(&client->dev, "fail to request irq\n");
goto err_free_mem;
According to the datasheet (p10) "The CHANGE line is active low and
signals when there is a change in state in the Detection or
Input status bytes. It is cleared (allowed to float high) when the
host reads the status bytes." As I understand, this means that we have
to monitor falling edges here.
Is there any reason to register the IRQ as IRQF_TRIGGER_NONE? Would
you accept the above patch instead, provided I send it in the required
format?
I add Voice Shen to the mail loop, who is writing above code.
Voice, will that IRQF_TRIGGER_XXXX changes impact other platforms?
Best Regards,
Josh Wu
Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
