Re: [PATCH] Input: synaptics - fix compile warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 23, 2012 at 5:31 PM, JJ Ding <jj_ding@xxxxxxxxxx> wrote:
> From: JJ Ding <dgdunix@xxxxxxxxx>
>
> Move synaptics_invert_y() inside CONFIG_MOUSE_PS2_SYNAPTICS to get rid of
> a compile warning when we don't select synaptics support.
>
> drivers/input/mouse/synaptics.c:53:12: warning: 'synaptics_invert_y' defined but not used [-Wunused-function]
>
> Cc: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>
> Signed-off-by: JJ Ding <dgdunix@xxxxxxxxx>

Reviewed-by: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>

> ---
>  drivers/input/mouse/synaptics.c |   20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 8081a0a..c778f27 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -45,16 +45,6 @@
>  #define YMIN_NOMINAL 1408
>  #define YMAX_NOMINAL 4448
>
> -/*
> - * Synaptics touchpads report the y coordinate from bottom to top, which is
> - * opposite from what userspace expects.
> - * This function is used to invert y before reporting.
> - */
> -static int synaptics_invert_y(int y)
> -{
> -       return YMAX_NOMINAL + YMIN_NOMINAL - y;
> -}
> -
>
>  /*****************************************************************************
>  *     Stuff we need even when we do not want native Synaptics support
> @@ -112,6 +102,16 @@ void synaptics_reset(struct psmouse *psmouse)
>  ****************************************************************************/
>
>  /*
> + * Synaptics touchpads report the y coordinate from bottom to top, which is
> + * opposite from what userspace expects.
> + * This function is used to invert y before reporting.
> + */
> +static int synaptics_invert_y(int y)
> +{
> +       return YMAX_NOMINAL + YMIN_NOMINAL - y;
> +}
> +
> +/*
>  * Send a command to the synpatics touchpad by special commands
>  */
>  static int synaptics_send_cmd(struct psmouse *psmouse, unsigned char c, unsigned char *param)
> --
> 1.7.10
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux