From: Rafael J. Wysocki: > On Friday, April 13, 2012, Mikko Vinni wrote: >> From: Rafael J. Wysocki: >> >> > On Friday, April 13, 2012, Mikko Vinni wrote: >> >> Bug report: >> >> https://bugzilla.kernel.org/show_bug.cgi?id=43099 >> >> ^^^ some of the home-work is already there, including dmesg with and without the patch with PCI debug on, which hopefully does the same as dev_info > > Please change that dev_dbg() in pci_restore_state() into dev_info() > and see how many times it gets printed with the commit applied (not reverted). I ran the dmesg through "uniq -c" and it looks like this: 1 ACPI: Low-level resume complete 1 PM: Restoring platform NVS memory 1 Enabling non-boot CPUs ... 1 Booting Node 0 Processor 1 APIC 0x1 1 CPU1 is up 1 ACPI: Waking up from system sleep state S3 10 pcieport 0000:00:02.0: restoring config space at offset 0x7 (was 0x20005151, writing 0x5151) 1 pcieport 0000:00:02.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) 1 pcieport 0000:00:04.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) 1 pcieport 0000:00:05.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) 10 pcieport 0000:00:06.0: restoring config space at offset 0x7 (was 0x20002121, writing 0x2121) 1 pcieport 0000:00:06.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) 1 pcieport 0000:00:0a.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) 1 ahci 0000:00:11.0: restoring config space at offset 0x1 (was 0x2300003, writing 0x2300007) 1 ohci_hcd 0000:00:12.0: restoring config space at offset 0x1 (was 0x2a00002, writing 0x2a00013) 1 ehci_hcd 0000:00:12.2: BAR 0: set to [mem 0xd2408500-0xd24085ff] (PCI address [0xd2408500-0xd24085ff]) 1 ehci_hcd 0000:00:12.2: restoring config space at offset 0x1 (was 0x2b00000, writing 0x2b00013) 1 ehci_hcd 0000:00:12.2: PME# disabled 1 ohci_hcd 0000:00:13.0: restoring config space at offset 0x1 (was 0x2a00002, writing 0x2a00013) 1 ehci_hcd 0000:00:13.2: BAR 0: set to [mem 0xd2408400-0xd24084ff] (PCI address [0xd2408400-0xd24084ff]) 1 ehci_hcd 0000:00:13.2: restoring config space at offset 0x1 (was 0x2b00000, writing 0x2b00013) 1 ehci_hcd 0000:00:13.2: PME# disabled 1 pata_atiixp 0000:00:14.1: restoring config space at offset 0x1 (was 0x2300011, writing 0x2300015) 1 radeon 0000:01:00.0: restoring config space at offset 0x1 (was 0x100003, writing 0x100407) 1 r8169 0000:09:00.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) 1 firewire_ohci 0000:0a:00.0: Refused to change power state, currently in D3 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0xf (was 0xffffffff, writing 0x10a) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0xe (was 0xffffffff, writing 0x0) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0xd (was 0xffffffff, writing 0x44) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0xc (was 0xffffffff, writing 0x0) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0xb (was 0xffffffff, writing 0x3600103c) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0xa (was 0xffffffff, writing 0x0) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0x9 (was 0xffffffff, writing 0xd1100c00) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0x8 (was 0xffffffff, writing 0xd1100c80) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0x7 (was 0xffffffff, writing 0x0) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0x6 (was 0xffffffff, writing 0x0) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0x5 (was 0xffffffff, writing 0xd1100d00) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0x4 (was 0xffffffff, writing 0xd1100000) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0x3 (was 0xffffffff, writing 0x800000) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0x2 (was 0xffffffff, writing 0xc001000) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0x1 (was 0xffffffff, writing 0x100007) 10 firewire_ohci 0000:0a:00.0: restoring config space at offset 0x0 (was 0xffffffff, writing 0x2380197b) 1 sdhci-pci 0000:0a:00.1: Refused to change power state, currently in D3 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0xf (was 0xffffffff, writing 0x10a) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0xe (was 0xffffffff, writing 0x0) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0xd (was 0xffffffff, writing 0xa4) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0xc (was 0xffffffff, writing 0x0) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0xb (was 0xffffffff, writing 0x3600103c) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0xa (was 0xffffffff, writing 0x0) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0x9 (was 0xffffffff, writing 0x0) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0x8 (was 0xffffffff, writing 0x0) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0x7 (was 0xffffffff, writing 0x0) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0x6 (was 0xffffffff, writing 0x0) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0x5 (was 0xffffffff, writing 0x0) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0x4 (was 0xffffffff, writing 0xd1100b00) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0x3 (was 0xffffffff, writing 0x800000) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0x2 (was 0xffffffff, writing 0x8800000) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0x1 (was 0xffffffff, writing 0x100007) 10 sdhci-pci 0000:0a:00.1: restoring config space at offset 0x0 (was 0xffffffff, writing 0x2382197b) 1 pci 0000:0a:00.2: Refused to change power state, currently in D3 10 pci 0000:0a:00.2: restoring config space at offset 0xf (was 0xffffffff, writing 0x10a) 10 pci 0000:0a:00.2: restoring config space at offset 0xe (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.2: restoring config space at offset 0xd (was 0xffffffff, writing 0xa4) 10 pci 0000:0a:00.2: restoring config space at offset 0xc (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.2: restoring config space at offset 0xb (was 0xffffffff, writing 0x3600103c) 10 pci 0000:0a:00.2: restoring config space at offset 0xa (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.2: restoring config space at offset 0x9 (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.2: restoring config space at offset 0x8 (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.2: restoring config space at offset 0x7 (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.2: restoring config space at offset 0x6 (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.2: restoring config space at offset 0x5 (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.2: restoring config space at offset 0x4 (was 0xffffffff, writing 0xd1100a00) 10 pci 0000:0a:00.2: restoring config space at offset 0x3 (was 0xffffffff, writing 0x800000) 10 pci 0000:0a:00.2: restoring config space at offset 0x2 (was 0xffffffff, writing 0x8050100) 10 pci 0000:0a:00.2: restoring config space at offset 0x1 (was 0xffffffff, writing 0x100003) 10 pci 0000:0a:00.2: restoring config space at offset 0x0 (was 0xffffffff, writing 0x2381197b) 1 jmb38x_ms 0000:0a:00.3: Refused to change power state, currently in D3 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0xf (was 0xffffffff, writing 0x10a) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0xe (was 0xffffffff, writing 0x0) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0xd (was 0xffffffff, writing 0xa4) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0xc (was 0xffffffff, writing 0x0) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0xb (was 0xffffffff, writing 0x3600103c) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0xa (was 0xffffffff, writing 0x0) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0x9 (was 0xffffffff, writing 0x0) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0x8 (was 0xffffffff, writing 0x0) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0x7 (was 0xffffffff, writing 0x0) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0x6 (was 0xffffffff, writing 0x0) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0x5 (was 0xffffffff, writing 0x0) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0x4 (was 0xffffffff, writing 0xd1100900) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0x3 (was 0xffffffff, writing 0x800000) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0x2 (was 0xffffffff, writing 0x8800000) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0x1 (was 0xffffffff, writing 0x100007) 10 jmb38x_ms 0000:0a:00.3: restoring config space at offset 0x0 (was 0xffffffff, writing 0x2383197b) 1 pci 0000:0a:00.4: Refused to change power state, currently in D3 10 pci 0000:0a:00.4: restoring config space at offset 0xf (was 0xffffffff, writing 0x10a) 10 pci 0000:0a:00.4: restoring config space at offset 0xe (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.4: restoring config space at offset 0xd (was 0xffffffff, writing 0xa4) 10 pci 0000:0a:00.4: restoring config space at offset 0xc (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.4: restoring config space at offset 0xb (was 0xffffffff, writing 0x3600103c) 10 pci 0000:0a:00.4: restoring config space at offset 0xa (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.4: restoring config space at offset 0x9 (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.4: restoring config space at offset 0x8 (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.4: restoring config space at offset 0x7 (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.4: restoring config space at offset 0x6 (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.4: restoring config space at offset 0x5 (was 0xffffffff, writing 0x0) 10 pci 0000:0a:00.4: restoring config space at offset 0x4 (was 0xffffffff, writing 0xd1100800) 10 pci 0000:0a:00.4: restoring config space at offset 0x3 (was 0xffffffff, writing 0x800000) 10 pci 0000:0a:00.4: restoring config space at offset 0x2 (was 0xffffffff, writing 0x8800000) 10 pci 0000:0a:00.4: restoring config space at offset 0x1 (was 0xffffffff, writing 0x100007) 10 pci 0000:0a:00.4: restoring config space at offset 0x0 (was 0xffffffff, writing 0x2384197b) 1 PM: noirq resume of devices complete after 8474.806 msecs 1 PM: early resume of devices complete after 0.194 msecs 1 ohci_hcd 0000:00:12.0: enabling bus mastering Interestingly, this only seems to happen after the first s2ram. https://bugzilla.kernel.org/attachment.cgi?id=72904 contains the dmesg from three s2ram's, and after the second and third one write seems to be enough. Even the failing firewire/card reader (another bug) is more quiet. ... (after the second s2ram, touchpad works after this) 1 CPU1 is up 1 ACPI: Waking up from system sleep state S3 1 pcieport 0000:00:02.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) 1 pcieport 0000:00:04.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) 1 pcieport 0000:00:05.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) 1 pcieport 0000:00:06.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) 1 pcieport 0000:00:0a.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) 1 ahci 0000:00:11.0: restoring config space at offset 0x1 (was 0x2300003, writing 0x2300007) 1 ohci_hcd 0000:00:12.0: restoring config space at offset 0x1 (was 0x2a00002, writing 0x2a00013) 1 ehci_hcd 0000:00:12.2: BAR 0: set to [mem 0xd2408500-0xd24085ff] (PCI address [0xd2408500-0xd24085ff]) 1 ehci_hcd 0000:00:12.2: restoring config space at offset 0x1 (was 0x2b00000, writing 0x2b00013) 1 ehci_hcd 0000:00:12.2: PME# disabled ... Mikko > > [Margin note: I think it would make more sense to read the value from > the register _after_ and not before the waiting and I'm not exactly sure why > msleep() is not used.] > > Thanks, > Rafael > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
