Re: [PATCH] matrix_keypad: convert to threaded IRQs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012-04-03 18:37, Dmitry Torokhov wrote:
On Tue, Apr 03, 2012 at 10:10:00AM +0200, Peter Rusko wrote:
Tested on Ka-Ro TX28 SOC

Needs justification; plus this is not how debounce works - you need to
postpone scan until IRQ line settles, not simply wait so many
milliseconds.
What is the difference there? The previous driver has the same effect,
it used a delayed work to wait:

	if (unlikely(keypad->scan_pending || keypad->stopped))
		goto out;

	disable_row_irqs(keypad);
	keypad->scan_pending = true;
	schedule_delayed_work(&keypad->work,
		msecs_to_jiffies(keypad->pdata->debounce_ms));

Are you saying that I should reschedule the scan every time an interrupt
arrives (before the 'goto out' line) and decrease timeout?


I think what you really need is request_any_context_irq().
In that case, I'll have to get back to delayed work.

Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux