On Tue, 3 Apr 2012, Benjamin Tissoires wrote: > > The hid bus is populated by devices created by the usb and bluetooth > > subsystems. The hid device is then broadcast to userland via uevents. > > Currently, the parsing of the hid reports is done during probe of > > the hid device, after the device has been broadcast. In order to > > allow for the report descriptors to influence the device properties, > > it is desirable to parse the device _before_ it is broadcast to > > userland. In actuality, the parsing depends only accidentally on > > the driver being present, so it can be trivially achieved. > > > > Something also needs to be done for the report_fixup handler, which > > seems to be the only hard device-driver coupling in the code. > > > > Signed-off-by: Henrik Rydberg <rydberg@xxxxxxxxxxx> > > --- > > drivers/hid/hid-core.c | 2 +- > > drivers/hid/usbhid/hid-core.c | 5 +++++ > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > index 35ba9d9..8a7b59e 100644 > > --- a/drivers/hid/hid-core.c > > +++ b/drivers/hid/hid-core.c > > @@ -658,7 +658,7 @@ int hid_parse_report(struct hid_device *device, __u8 *start, > > hid_parser_reserved > > }; > > > > - if (device->driver->report_fixup) > > + if (device->driver && device->driver->report_fixup) > > start = device->driver->report_fixup(device, start, &size); > > Well, this is not a good solution for the following drivers: > hid-zydacron > hid-prodikeys > hid-uclogic > hid-samsung > hid-sony, etc... > > they all use report_fixup and as the parse is made only once, they > won't be able to work properly. For completness -- please see a discussion that's a little bit related to this (and namely the patch I have proposed yesterday) here: http://www.spinics.net/lists/linux-input/msg20061.html -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
