Hi Henrik, well, I'm giving you my answer here as it will be more convenient than in the previous thread. So, I made a few tests yesterday, and I have now a clearer idea about this solution: generally, I like it. Furthermore, it should help us build new classes of devices without involving hid-core, which is great. However, I have a few minors concerns, and a major one. The major one comes with patch 3: introducing the hid_parse function in usbhid is great but it interferes with report_fixup mechanism. That means that several drivers won't work with this solution. Now the minors: - as mentioned, the patches do not apply on Jiri's tree, which means that we are missing the detection of the serial protocol (see comment in patch 4). - shouldn't we introduce the same behavior for bluetooth (hidp) devices -> to be able to separate the handling of the magicmouse for instance)? - as the hid_parse function is already called, shouldn't we remove the calls in the other drivers? Cheers, Benjamin On Tue, Apr 3, 2012 at 09:05, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote: > Hi Jiri, > > These patches were first sent out as a reply to Benjamin's autoloading > patch (http://www.spinics.net/lists/linux-input/msg20001.html), but it > seems more appropriate as an RFC. > > The idea is to parse the hid descriptors before adding the device, > such that the device identifier, in particular the device/modalias, > can be augmented by the report information. This approach solves the > generic auto-loading problem we face today, here exemplified by a > solution for hid-multitouch. > > The patches apply cleanly to 3.3 for easy testing. > > Thanks, > Henrik > > Henrik Rydberg (5): > hid: Remove multitouch quirk > hid-multitouch: Prepare driver for new device ids > hid: Parse the device before adding it > hid: Add idtags to modalias > hid: Remove multitouch devices from blacklist > > drivers/hid/hid-core.c | 88 ++++++++------------------- > drivers/hid/hid-input.c | 11 ---- > drivers/hid/hid-multitouch.c | 124 +++++++++++++++++++++------------------ > drivers/hid/usbhid/hid-core.c | 5 ++ > include/linux/hid.h | 8 ++- > include/linux/mod_devicetable.h | 2 +- > scripts/mod/file2alias.c | 2 + > 7 files changed, 107 insertions(+), 133 deletions(-) > > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
