On Mon, Apr 02, 2012 at 06:37:04PM +0300, Oskari Saarenmaa wrote: > On 02/04/12 18:05, Chase Douglas wrote: > >On 04/02/2012 07:57 AM, Oskari Saarenmaa wrote: > >>On 02/04/12 17:22, Chase Douglas wrote: > >>>On 04/01/2012 11:30 AM, Oskari Saarenmaa wrote: > >>>>On-pad clicks in absolute positioning single-finger mode are reported > >>>>without the PHY_BTN bit set, the on-pad clicks are handled by userspace > >>>>so the kernel shouldn't report them as real clicks. > >>> > >>>What is the definition of an "on-pad" click? > >> > >>In this case it's a tap on the pad without actually clicking it. The > >>Asus UX21 Zenbook has a touchpad that can be tapped or clicked. > >>Single-finger taps on it are reported by the touchpad with FSP_PB0_LBTN > >>flag set and FSP_PB0_PHY_BTN not set. > > > >So if I understand correctly, the device currently emits a "physical" > >left button click event when the clickpad is tapped. Your patch will > >prevent this event from being sent to userspace, since userspace does > >its own tap detection. Is that correct? > > Yes. Without this patch there's no way to disable click-on-tap in > userspace. Makes sense to me. Tai-hwa, any objections? BTW, I think we should suppress creating vscroll, hscroll and probably flags attributes when touchpad is in absolute mode since they are not applicable there (via attribute group's visible() methos). I am always takig patches ;) Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
