On 3/29/2012 9:14 PM, Stephen Warren wrote: >> > + size = proplen / sizeof(u32); >> > + if (size > idev->keycodemax) { >> > + dev_err(dev, "OF: %s overflow\n", propname); >> > + return -EINVAL; >> > } > That is checking the number of entries in the property, not the values > of the MATRIX_SCAN_CODE values derived from those entries. I'd say just > remove this check. See below. > Stephen, I have added a check on return value of MATRIX_SCAN_CODE(), but would still keep above check. Number of keys passed should also be less than keycodemax. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html