Re: [PATCH 1/2] input/of_keymap: Convert kzalloc to devm_kzalloc derivative

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/26/2012 03:45 AM, Viresh Kumar wrote:
> matrix_keyboard_of_fill_keymap() routines allocates memory using kzalloc()
> routine. It is freed on call to matrix_keyboard_of_free_keymap() routine.
> 
> This patch converts these kzalloc() calls to devm_kzalloc() and thus we don't
> require matrix_keyboard_of_free_keymap() anymore.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxx>

The Tegra-related parts,
Acked-by: Stephen Warren <swarren@xxxxxxxxxxxxx>

But that said, Dmitry specifically requested that the devm_* function
not be used during initial review of this code; IIRC he preferred just
doing the explicit frees. I can't find a link right now though.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux