On Tue, Jan 03, 2012 at 02:37:44PM -0800, Stephen Warren wrote:
> Olof Johansson wrote at Tuesday, January 03, 2012 2:37 PM:
> > This adds a simple device tree binding for simple key matrix data and
> > a helper to fill in the platform data.
> >
> > The implementation is in a shared file outside if drivers/input/keyboard
> > since some drivers in drivers/input/misc might be making use of it
> > as well.
> >
> > Changes since v3:
> > * Dropped compatible field in matrix-keymap.txt
> > * Dropped linux,fn-key
> > * Dropped linux,fn-keymap optional property but included guideline on
> > naming convention
> > * Now passing property name in to the helper function (or will assume
> > "linux,keymap" if passed NULL)
>
> > diff --git a/drivers/input/of_keymap.c b/drivers/input/of_keymap.c
>
> > +struct matrix_keymap_data *
> > +matrix_keyboard_of_fill_keymap(struct device_node *np, char *propname)
> > +{
> ...
> > + kd = kmalloc(sizeof(*kd), GFP_KERNEL);
> > + if (!kd)
> > + return NULL;
>
> Should that use kzalloc in case struct matrix_keymap_data grows some
> new fields that people will assume are set to zero since the struct
> would usually be in .data? Still, people should probably grep the code
> when making such changes...
>
> Otherwise,
>
> Acked-by: Stephen Warren <swarren@xxxxxxxxxx>
>
Applied, thanks everyone.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
