Thanks for the review and sorry for the late reply, I was away all
February without access to the laptop.
28.01.2012 22:56, Dmitry Torokhov kirjoitti:
+ case FSP_PKT_TYPE_NOTIFY:
+ /* Notify packets are sent with Cx and newer
+ * touchpads if register 0x90 bit 1 is set.
+ */
Do we need to support the non-absolute mode if we can support absolute
mode for the device? Users expect to have true multi-touch support
nowadays, I think we should keep the driver as simple as possible and
support only absolute mode for MT devices.
This part can be removed as support for it is not enabled anyway in this
driver, I just left it there as it was the first thing I was able to
figure out when I started experimenting with the driver & hardware
before receiving updated documentation for it. If someone wants to work
on it it's now properly documented in Documentation/input/sentelic.txt
+ if ((packet[0]& (BIT(4)|BIT(5))) == 0&& l_btn) {
+ /* on pad click, let other components handle this.
+ * NOTE: do not filter out on-pad clicks when
+ * we're in multitouch mode, BIT(5), they are real
+ * clickpad-clicks, not just single finger taps.
+ */
+ l_btn = 0;
Hmm, so this is a clickpad device? We need to set clickpad property
then.
Ok.
+ }
+
+ if (packet[0]& BIT(5)) {
+ /* multitouch mode: two fingers down */
+ fingers++;
+ if ((packet[0]& BIT(4)) == 0&& l_btn&& r_btn) {
+ /* middle-click in multitouch mode */
+ l_btn = 0;
+ r_btn = 0;
+ m_btn = 1;
+ }
The middle button emulation should be handled in userspace. Let
synaptics X driver deal with it.
Does the synaptics driver actually handle this? This is implemented
according to the documentation, which says "If bit 1 and 0 are all 1 and
bit 4 is 0, the middle external button is pressed." but since my
hardware does not have a "middle external button" I haven't actually
tested this part.
+ if (packet[0]& BIT(2)) {
+ /* right finger down, ignore the event */
Needs better comment.
Ok.
I'll post an updated patch that addresses the above comments.
/ Oskari
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
