Hi Tobias, On Wed, Mar 07, 2012 at 02:44:24PM +0100, Tobias Klauser wrote: > It doesn't make much sense to allocate struct ps2if and struct serio > separately as they're allocated and used in conjunction. > Actually, it does. Serio is a refcounted structure and has different lifetime rules than struct ps2if. It may get deleted by serio_unregister_port() or it may live on until after ps2if is freed and altera_ps2 module is unloaded and it should stay allocated separately. > Also ps2if->io wasn't freed in altera_ps2_remove() even tough it should > have been and thus caused a memory leak. This is also (implicitely) > fixed by this change. No, there was't a memory leak as serio core takes care of freeing the object when refrerence count reaches 0. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
