On Sun, Mar 4, 2012 at 4:41 PM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > Hi Javier, > > On Wed, Feb 15, 2012 at 11:42:52AM +0100, Javier Martinez Canillas wrote: >> From: Javier Martinez Canillas <martinez.javier@xxxxxxxxxxxx> >> >> In the cyttsp_probe() function the struct device *dev pointer was >> dereferenced before checking if it was NULL. >> >> Now dev is never NULL since both I2C and SPI bus drivers pass a pointer to a >> member of an previously allocated structure. But others bus drivers can do >> it differently so is better to sanity check instead of trust in the callers. >> > > I already have a patch that simply removes the checks ofr dev and > bus_ops - cyttsp_probe is only called by bus-specific code and they are > not coming form platform data so there is no chance they will be NULL. > And anyone writing a new bus intefcae will get a nice oops first time > they try loading the module so they'll see the problem right away too. > > Thanks. > > -- > Dmitry Yes, I agree with you. Since cyttsp_probe is only called by bus specific code, removing the checks is better. Thanks and best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
