Re: [PATCH v3 7/7] input: wacom - add 0xE5 (MT device) support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 20, 2012 at 2:24 AM, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote:
> Hi Chris,
>
> The input_mt_report_slot_state should be used instead of directly
> setting the tracking id. If the id reported by the hardware is not
> bounded by some small number (so that it maps to slots), you will have
> to keep the translation table in the driver.
>
> Also, the commit message could need some love.
>
> Thanks,
> Henrik

Thank you for review, Henrik.

Makes sense.  hid-multitouch has an example find_slot_from_contactid()
that could be used as reference here if the ID's are not bound.

I'll have to table patches 6 and 7 until either Ping is available to
update them or can provide me some more details on tracking ID
behavior.

Anyone have comments on patches 1-5 that are for Wireless Bamboo support?

Thanks again,
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux