On Wed, Jan 18, 2012 at 10:20 AM, Javier Martinez Canillas
<martinez.javier@xxxxxxxxx> wrote:
> On Wed, Jan 18, 2012 at 10:12 AM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
>> Hi Javier,
>>
>> On Sat, Jan 14, 2012 at 03:32:51AM +0100, Javier Martinez Canillas wrote:
>>> +
>>> +static int __cyttsp_disable(struct cyttsp *ts)
>>> +{
>>> + u8 sleep_mode = 0;
>>> + int retval = 0;
>>> +
>>> + if (ts->pdata->use_sleep && ts->power_state == CY_ACTIVE_STATE) {
>>> + sleep_mode = ts->pdata->use_sleep;
>>> + retval = ttsp_write_block_data(ts, CY_REG_BASE,
>>> + sizeof(sleep_mode), &sleep_mode);
>>> + if (retval >= 0) {
>>> + ts->power_state = CY_SLEEP_STATE;
>>> + disable_irq(ts->irq);
>>> + }
>>
>> I thought we agreed that we should put the device to sleep
>> unconditionally and not have use_sleep option?
>
> Yes, we did. Sorry, I've missed that. I'll change it and resend.
>
>>
>> Thanks.
>>
>> --
>> Dmitry
>> --
Thanks Dmitry for the review.
Any more issues you have found? So I can fix all of them for the next
version of the patch.
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
