Hi Alan, On Wednesday, January 11, 2012 10:35:50 PM Alan Cox wrote: > I'm currently adding the Fujitsu Q550 to the fujitsu-tablet driver > (http://sourceforge.net/projects/fjbtndrv/files/fjbtndrv/) > > The Q550 has 3 buttons - a direction flipping button, a keyboard button > and a ctrl-alt-delete button. > > It's labelled as such, it acts as such and I'm tempted to map it as such > including modifiers but that does rather violate the usual behaviour we > expect. Reading manual it looks like it is a dedicated SAK button. While we do not currently have a dedicated key code for it we could easily add one. > > So how should it be mapped ? > > I'll send Robert Gerlach a patch once I have a good answer on that one. > It would also be nice to get the kernel bits for this driver upstream. > Barring some trivial printk/pr_debug things it looks to me to be in > perfectly good shape to go upstream, and it's kind of handy when the > buttons work on your tablet ! Yes, the driver indeed looks nice, changing a few printk and making sure we do not leak ACPI statuses into the other layers (like what happens in fujitsu_module_init() - should convert acpi status to linux errno upon failure - if acpi_bus_register_driver() really returns acpi status) should make it ready for mainline. I think tt should go to Matthew's drivers/platform subtree though. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
