Re: [PATCH] HID: usbhid: fix dead lock between open and disconect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Donnerstag, 12. Januar 2012, 10:42:22 schrieb Ming Lei:
> There is no reason to hold hiddev->existancelock before
> calling usb_deregister_dev, so move it out of the lock.
> 
> The patch fixes the lockdep warning below [1].
> 
> [1], lockdep warning

Hi,

you should however hold the lock while you unset hiddev->exist
and you should unset hiddev->exist before you call usb_deregister_dev().
So the diagnosis is very good, but the patch needs a bit elaboration.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux