On 01/11/2012 11:04 AM, Henrik Rydberg wrote: >>> Applied, however I removed stable notation as this change IMO does not >>> qualify for the stable since it does not address a regression. >> >> It's not a regression per-se, but we want to fix buttonpad support, and >> we can't do that without this patch. It's a clear bug that when the >> property was added we did not set the property in the devices that need it. > > The current behavior depends on userspace and is not a kernel bug, > please stop the nonsense already. > > For bcm5974 devices, extracting buttonpad properties has been possible > since early 2009 (158e9287). The mechanism, predating the input > properties interface by nearly two years, has been used in the > multitouch and mtrack X drivers ever since. To those users, the > present patch has no effect at all. Just because an alternative interface has existed does not mean there isn't a bug. A device that has a physical property, but does not set the property bit in the driver is a real bug that needs to be fixed. Userspace should not have to quirk around broken implementations. It's true that userspace can quirk around things in a kernel that predates the property bits, but where the property bits are available the devices *must* set them or else things will break. -- Chase -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
