Re: [RFC PATCH 2/11] input: RMI4 core bus and sensor drivers.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shubhrajyoti,

Thanks for the feedback.  Please see my comments below.


On 01/01/2012 10:38 PM, Shubhrajyoti wrote:
Hi Christopher,

On Thursday 22 December 2011 07:39 AM, Christopher Heiny wrote:
Signed-off-by: Christopher Heiny<cheiny@xxxxxxxxxxxxx>

Cc: Dmitry Torokhov<dmitry.torokhov@xxxxxxxxx>
Cc: Linus Walleij<linus.walleij@xxxxxxxxxxxxxx>
Cc: Naveen Kumar Gaddipati<naveen.gaddipati@xxxxxxxxxxxxxx>
Cc: Joeri de Gram<j.de.gram@xxxxxxxxx>

---

  drivers/input/rmi4/rmi_bus.c    |  436 ++++++++++++
  drivers/input/rmi4/rmi_driver.c | 1488 +++++++++++++++++++++++++++++++++++++++
  drivers/input/rmi4/rmi_driver.h |   97 +++
  3 files changed, 2021 insertions(+), 0 deletions(-)

diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c

[snip]

+#ifdef CONFIG_PM
+static int rmi_bus_suspend(struct device *dev)
+{
+#ifdef GENERIC_SUBSYS_PM_OPS
+	const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;
+
+	if (pm&&  pm->suspend)
+		return pm->suspend(dev);
If driver-pm- suspend is not there should you not fall back to . suspend ?

I'm looking into using dev->driver->suspend() here. It wants a pm_message_t for the pm state. We don't have that on entry to bus_suspend, though. Any suggestion as to what we should pass?

				Thanks,
					Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux