Hi Alan, On Thu, Dec 15, 2011 at 10:18:47PM +0000, Alan Cox wrote: > From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > This will improve the output of the sensor. > ... > > +/* Configures the sampling method */ > +static int mpu3050_hw_init(struct mpu3050_sensor *sensor) This should be __devinit. ... > @@ -336,6 +423,10 @@ static int __devinit mpu3050_probe(struct i2c_client *client, > > pm_runtime_set_active(&client->dev); > > + error = mpu3050_hw_init(sensor); > + if (error) > + goto err_free_mem; We should go to err_pm_set_suspended, not err_free_mem. I fixed it up locally. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html