Re: [PATCH 1/1] input: keyboard: Set configuration registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, December 09, 2011 12:10:43 PM Stephen Warren wrote:
> Shridhar Rasal wrote at Friday, December 09, 2011 12:29 AM:
> > To: dmitry.torokhov@xxxxxxxxx
> > Cc: rydberg@xxxxxxxxxxx; Stephen Warren; Rakesh Iyer;
> > linux-kernel@xxxxxxxxxxxxxxx; linux- input@xxxxxxxxxxxxxxx;
> > linux-tegra@xxxxxxxxxxxxxxx; Shridhar Rasal Subject: [PATCH 1/1] input:
> > keyboard: Set configuration registers
> > 
> > -Set only REQUIRED row and column configuration register to
> > PROPER values to avoid continuously generating KBC input events.
> > -Use *en* field in pin_cfg, to check GPIO_x_ROW_EN register
> > should be set or clear.
> > 
> > Signed-off-by: Shridhar Rasal <srasal@xxxxxxxxxx>
> 
> I wondered if num==0 could be used instead of a new en field, but 0 is a
> valid row/column number, so no. As such,
> 
> Acked-by: Stephen Warren <swarren@xxxxxxxxxx>

Can we pass in number of pin_cfg instances in pdata and simply do not
mention unneeded pins instead?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux