On Wed, Dec 07, 2011 at 05:41:37PM -0800, Jeremy Fitzhardinge wrote: [...] > diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c > index 6512b20..ec36c82 100644 > --- a/drivers/acpi/ac.c > +++ b/drivers/acpi/ac.c > @@ -142,6 +142,9 @@ static int get_ac_property(struct power_supply *psy, > case POWER_SUPPLY_PROP_ONLINE: > val->intval = ac->state; > break; > + case POWER_SUPPLY_PROP_SCOPE: > + val->intval = POWER_SUPPLY_SCOPE_SYSTEM; > + break; > default: > return -EINVAL; > } Mm... how about the rest of the drivers? I.e. drivers/power/*battery.c? I think it's not a great idea to patch every driver, would be better to make it similar to how we handle power_supply.type (w/ default value 'SYSTEM'). But, thinking more about it... personally, from the ABI point of view, I'd like to just see some kind of 'supplicants' directory in the power_supply instances, with symlinks to an appropriate devices. I.e. /sys/class/power_supply/battery/supplicants/<device_name> is a symlink to /sys/class/HID/.../device. With a special meaning of an empty directory (or non-existent, or w/ a symlink pointing to '/sys/devices/system') -- system power. That way we may describe any possible power hierarchy. >From the implementation point of view, for now power_supply may just conditionally (by introducing power_supply.not_system_power flag) expose power_supply.dev->parent to /sys/.../supplicants. Thanks, -- Anton Vorontsov Email: cbouatmailru@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
