On Wed, 16 Nov 2011, David Herrmann wrote: > >> -#define WIIMOTE_VERSION "0.2" > >> +#define WIIMOTE_VERSION "0.3" > > > > Do we really need this? > > > > I generally prefer not having any file versioning for the files that are > > implicitly tracked by kernel git. > > No, not at all. But I thought this was common practice. I have removed > it all together. The next series will be updated. It definitely might make sense for your internal tracking during driver development. I just would like to have it dropped for final merge. Otherwise, I have just finished first round of review, and overall the driver looks fine, thanks! -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
