Re: [PATCH V4] input: add EETI eGalax I2C capacitive multi touch driver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

On 2011-11-12,PM4:02, Dmitry Torokhov wrote:

> On Sat, Nov 12, 2011 at 02:12:37PM +0800, Zhang Jiejing wrote
>> 
>> V4 changes:
>> * fix some typo
>> * don't let i2c_master_recv spin indefinitely
>> * clean up the bit set of probe function
>> * clean up egalax_ts_remove  input_unregister_device order
> 
> No, it is not the order I complained about, input_free_device() shoudl
> not be called at all after calling input_unregister_device().
> 

I know the input_free_device call after input_unregister_device() maybe cause NULL pointer reference, sorry for I don't tested rmmod this module, I always buildin this module in my test env.

I will pay attention to it.

Thanks for your review.

> Fixed up locally and applied.
> 
Thanks.

Best Regards
Jiejing

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux