On 11/08/2011 10:36 AM, Daniel Drake wrote:
On Tue, Nov 8, 2011 at 12:34 AM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>> @@ -968,11 +1030,29 @@ int synaptics_init(struct psmouse *psmouse)
>> psmouse->rate = 40;
>> }
>>
>> + err = sysfs_create_file(&psmouse->ps2dev.serio->dev.kobj,
>> +&psmouse_attr_synaptics_disable_gesture.dattr.attr);
>> + if (err) {
>> + dev_err(&psmouse->ps2dev.serio->dev,
>> + "Failed to create disable_gesture attribute (%d)", err);
>> + goto init_fail;
>> + }
>
> This attribute does not make sense in absolute mode so we should only
> create it when relative mode is requested.
I think it could make some sense - to me it seems possible that there
would be a use case where absolute input is requested but the software
chooses to let the hardware do the gesture detection. But I don't know
of such a use case, and it isn't interesting for OLPC, so either way
is fine with me.
I agree with Daniel's statement.
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
