Hi Javier,
On Mon, Nov 07, 2011 at 09:17:57AM +0100, Javier Martinez Canillas wrote:
> Hello Dmitry,
>
> Do you have any comments on this issue?
>
Sorry for the delay and I promise your driver is next on my list.
The driver seems in much better shape than it was last time I looked at
it. Below are 2 tiny patches I still have from last time I tried
going over the code.
Thanks.
--
Dmitry
Input: cyttsp - fix use-after-free in syttsp_release
From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Once input_unregister_device() is called we may not assume that
ts->input contains valid pointer. Besides, input core takes care of
freeing MT slot memory.
Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
---
drivers/input/touchscreen/cyttsp/cyttsp_core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/input/touchscreen/cyttsp/cyttsp_core.c b/drivers/input/touchscreen/cyttsp/cyttsp_core.c
index 103ac39..240998d 100644
--- a/drivers/input/touchscreen/cyttsp/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp/cyttsp_core.c
@@ -660,7 +660,6 @@ void cyttsp_core_release(void *handle)
input_unregister_device(ts->input);
if (ts->platform_data->exit)
ts->platform_data->exit();
- input_mt_destroy_slots(ts->input);
kfree(ts);
}
}
Input: cyttsp - remove ext() method from bus ops
From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
It is not used anywhere and so is not needed
Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
---
drivers/input/touchscreen/cyttsp/cyttsp_core.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/input/touchscreen/cyttsp/cyttsp_core.h b/drivers/input/touchscreen/cyttsp/cyttsp_core.h
index efefdb9..c4c7d9e 100644
--- a/drivers/input/touchscreen/cyttsp/cyttsp_core.h
+++ b/drivers/input/touchscreen/cyttsp/cyttsp_core.h
@@ -44,7 +44,6 @@
struct cyttsp_bus_ops {
s32 (*write)(void *handle, u8 addr, u8 length, const void *values);
s32 (*read)(void *handle, u8 addr, u8 length, void *values);
- s32 (*ext)(void *handle, void *values);
struct device *dev;
};
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
