Re: [PATCH 2/6] Input: wacom - remove unused bamboo HID parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 20, 2011 at 4:17 PM, Ping Cheng <pinglinux@xxxxxxxxx> wrote:
> On Sun, Oct 16, 2011 at 6:29 PM,  <chris@xxxxxxxxxxxxxx> wrote:
>> From: Chris Bagwell <chris@xxxxxxxxxxxxxx>
>>
>> Bamboo's do not declared a Digitizer-Stylus so the if() was
>> never executed.  wacom_features already contains correct stylus
>> packet length.
>
> Since this change affects all Bamboo series, I assume you have tested
> it with your old Bamboo pen and touch. If so,

Yes, been tested with 1st gen Bamboo as well.

>
>> Signed-off-by: Chris Bagwell <chris@xxxxxxxxxxxxxx>
>
> Acked-by: Ping Cheng <pingc@xxxxxxxxx> for the whole set.

Thanks,
Chris

>
> Ping
>
>> ---
>>  drivers/input/tablet/wacom_sys.c |    4 ----
>>  1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
>> index 4f35473..620f0c3 100644
>> --- a/drivers/input/tablet/wacom_sys.c
>> +++ b/drivers/input/tablet/wacom_sys.c
>> @@ -245,8 +245,6 @@ static int wacom_parse_hid(struct usb_interface *intf, struct hid_descriptor *hi
>>                                                /* penabled only accepts exact bytes of data */
>>                                                if (features->type == TABLETPC2FG)
>>                                                        features->pktlen = WACOM_PKGLEN_GRAPHIRE;
>> -                                               if (features->type == BAMBOO_PT)
>> -                                                       features->pktlen = WACOM_PKGLEN_BBFUN;
>>                                                features->device_type = BTN_TOOL_PEN;
>>                                                features->x_max =
>>                                                        get_unaligned_le16(&report[i + 3]);
>> @@ -295,8 +293,6 @@ static int wacom_parse_hid(struct usb_interface *intf, struct hid_descriptor *hi
>>                                                /* penabled only accepts exact bytes of data */
>>                                                if (features->type == TABLETPC2FG)
>>                                                        features->pktlen = WACOM_PKGLEN_GRAPHIRE;
>> -                                               if (features->type == BAMBOO_PT)
>> -                                                       features->pktlen = WACOM_PKGLEN_BBFUN;
>>                                                features->device_type = BTN_TOOL_PEN;
>>                                                features->y_max =
>>                                                        get_unaligned_le16(&report[i + 3]);
>> --
>> 1.7.6.4
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux