On 10/18/11 16:48, Ricardo Ribalda Delgado wrote:
> Improve probing of the cma3000 chip, by checking the revision of the
> device.
Please carry acks forward with new versions if the patch hasn't changed
significantly.
>
> ---
>
> v2: Fixes suggested by Jonathan Cameron
> -Remove WhoamI pr_info
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>
> ---
> drivers/input/misc/cma3000_d0x.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c
> index 604a32f..18ac912 100644
> --- a/drivers/input/misc/cma3000_d0x.c
> +++ b/drivers/input/misc/cma3000_d0x.c
> @@ -27,6 +27,8 @@
>
> #include "cma3000_d0x.h"
>
> +#define CMA3000_REV 0x10
> +
> #define CMA3000_WHOAMI 0x00
> #define CMA3000_REVID 0x01
> #define CMA3000_CTRL 0x02
> @@ -418,7 +420,11 @@ struct cma3000_accl_data *cma3000_init(struct device *dev, int irq,
> error = rev;
> goto err_free_mem;
> }
> -
> + if (rev != CMA3000_REV) {
> + error = -EINVAL;
> + pr_err("CMA3000 Accelerometer: Unknown Revision %x\n", rev);
> + goto err_free_mem;
> + }
> pr_info("CMA3000 Accelerometer: Revision %x\n", rev);
>
> error = request_threaded_irq(irq, NULL, cma3000_thread_irq,
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
