Am Dienstag, 11. Oktober 2011, 22:42:50 schrieb Matthew Garrett: > On Tue, Oct 11, 2011 at 01:09:21PM +0200, Oliver Neukum wrote: > > Am Dienstag, 11. Oktober 2011, 13:04:21 schrieb Henrik Rydberg: > > > Problem: the hid keyboard driver refuses to suspend while a key is > > > pressed, which is fine per se, but there is no indication presented to the power layer, > > > resulting in a failed suspend and (due to complex reasons it seems) disabled autosuspend. > > > > That is a bug. Autosuspend at a later date should happen. > > Yeah, there's definitely something broken here. If I hold down a key on > a USB keyboard for more than two seconds then it attempts to suspend but > fails. Releasing the key triggers another usb_mark_busy() but the core > never tries to suspend it again. What /does/ trigger a second attempt at > suspend is toggling an LED on and then off. It seems to me that rpm_suspend() in drivers/base/power has already called pm_runtime_cancel_pending(dev) unconditionally before calling rpm_callback() And afterwards the timer is not restarted. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html