Hi Daniel, On Mon, Oct 10, 2011 at 08:24:08PM +0100, Daniel Drake wrote: > 3. The issue of the input layer releasing all our keys is left > unresolved with this approach. > I think input layer releasing keys at resume time is actually in the wrong here, as it meddles with device state after physical device (i8042, atkbd, etc) are fully woken up. IIRC I put releasing originally in resume because I was concerned with events getting discarded after S2D because we thew away the state that happens after taking snapshot and there weren't enough granularity in PM callbacks to differentiate between S2D and S2R. I believe if we move release of the keys into suspend handlers then input core should not get into the middle of things for your case as you said that the OLPC device will not suspend with a key still pressed and upon release we would not be doing anything with key state (but restore LED/SOUND only) which you do not care about. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
