On Fri, Oct 07, 2011 at 06:39:37PM +0100, Matthew Garrett wrote: > On Fri, Oct 07, 2011 at 07:42:14PM +0200, Henrik Rydberg wrote: > > On Fri, Oct 07, 2011 at 06:13:25PM +0100, Matthew Garrett wrote: > > > I've seen the occasional error message on my 3,1, but I haven't seen any > > > looping suspend/resume. > > > > You need to sprinkle some outputs in the actual autosuspend machinery to see it. > > Can you describe exactly what you're seeing? With a corrected version of your patch, which enables autosuspend while the device file is open, I see the power layer repeatedly suspending and resuming the usb device in question, even while constantly moving a finger around on the pad. In conjunction with this behavior, I see error messages indicating unknown/faulty packets appearing in the bcm5974 interrupt handler. For the next version of the patch, please add a) why you want to change the current behavior, b) what the patch is supposed to do, and c) what exact devices are known to work with the patch. If there are any strange error messages appearing as a result of the patch, mentioning them would be minimum. Better yet, an explanation of why they appear, or how an improved patch makes them disappear would be great. Thanks, Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
