Hi Stephen Sorry for the messup! On 2011-09-20 at 03:26:27 +0200, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > On Mon, 19 Sep 2011 11:09:51 +0200 Tobias Klauser <tklauser@xxxxxxxxxx> wrote: > > > > Use the of_property_read_u32 helper function to retreive u32 values > > from the device tree. Also do not pass the len parameter to > > of_get_property if it isn't checked afterwards. > > > > Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx> > > --- > > v2: Fix build failure caused by a missing opening brace (reported by > > Stephen Rothwell) > > Sure, but it will still generate all the warnings I reported as "reg" is > the wrong type now. > > drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_get_devtree_pdata': > drivers/input/keyboard/gpio_keys.c:500:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type > include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **' > drivers/input/keyboard/gpio_keys.c:504:19: warning: assignment makes integer from pointer without a cast > drivers/input/keyboard/gpio_keys.c:508:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type > include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **' > drivers/input/keyboard/gpio_keys.c:509:20: warning: assignment makes integer from pointer without a cast > drivers/input/keyboard/gpio_keys.c:515:3: warning: passing argument 3 of 'of_property_read_u32' from incompatible pointer type > include/linux/of.h:268:19: note: expected 'u32 *' but argument is of type 'const u32 **' > drivers/input/keyboard/gpio_keys.c:516:33: warning: assignment makes integer from pointer without a cast Stupid me was compiling iwht the wrong .config (which hasn't CONFIG_OF set) all the time, that's why I never noticed any of the errors/warnings in the part I actually changed. Sorry, I'll send another patch, hopefully the final one. Thanks a lot for your help Tobias -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
